[bisq-network/bisq] [1.5.4] We need to use the getMapOfAllData method for HistoricalDataStoreServices (#5030)

[chimp1984]

>It is still not clear to me why we did not see much more AccountAgeWitness data but only one in massive numbers...

I found out the reason:
AccountAgeWitness has 1 day date tolerance, if its older the addPersistableNetworkPayload returns with false and do not relay the data. This helps us as the data which flooded the network is now > 1 day so it stopped flooding. This is also the reason why not all AccountAgeWitness data from hsitorical data store did flood the network. They got though republished but they got ignored by all peers as the date was too old.

The hash of that data of the problematic item was in the historical data store with an older date, but the user had for some reason not that historical data store or lost the live data so he could not find his AccountAgeWitness with the original date and created a new one with the date of 29.12. The other network peers had that hash in historical data but due the bug fixed in that PR it was not found so it got processed further and relayed again.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5030#issuecomment-752836337
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201230/0faf0c99/attachment.htm>