[bisq-network/bisq] Buy tx are recorded as sell tx and vice versa (#5035)

Manuel notifications at github.com
Thu Dec 31 13:13:19 CET 2020


### Description

Transaction side (Buy/Sell) is recorded backwards on Portfolio History and also when exporting transactions to csv

#### Version

This happens on current version v.1.5.3, but it seems that this is a bug from version 1.1.5 and previous versions (August 2019), so transactions made with those versions are wrongly recorded in the database, so they are still wrongly shown at Portfolio / History in current versions.

### Steps to reproduce

You need to have transactions previous to August 2019.  Go to Portfolio / History and pick a transaction older than August 2019. See below how at the top Bisq says I am the buyer, but in the payment details it says I am the seller.  I have checked it with the bank and I was the seller.

![image](https://user-images.githubusercontent.com/17677608/103409827-d8bed880-4b68-11eb-8f81-e6e0107f0db1.png)

 

### Expected behaviour

To correctly record and show buy transactions as buy transactions and sell transactions as sell transactions

### Actual behaviour

Old transactions (older than august 2019) are showed with the side reversed.  This is also happening when exporting those transactions to csv.  Most transactions prior to that date have the side reversed, but there are just a few that are correct. I have not figured out any pattern so far. 

#### Device or machine

Windows 7


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5035
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20201231/badbc159/attachment.htm>


More information about the bisq-github mailing list