[bisq-network/bisq] Accept old trade statistic object (#3933)

Christoph Atteneder notifications at github.com
Mon Feb 3 13:48:59 UTC 2020


Just to make the different use cases more clear:

1) Old clients
As they still have their local trade statistics they will still see the trade statistics.
- If a new trade is added and both parties are on the old version the trade will show up in the trade statistics for the clients.
- If a new trade is added and the client receives the trade statistics object from the seednode (or any other v1.2.6 node) it won't be shown in the trade statistics as it is seen as invalid trade statistics object (trade deposit tx id is null).

2) New clients v1.2.6+
Nothing changes for the new clients. They will see trades created by old clients and trades by new clients.

Seednodes:
Starting with v1.2.6 they will load the trade statistic object in memory and set the deposit tx id of the trade statistics objects to null (also for all old trades). We should update the seednodes first before releasing, so they are not missing out any trades by new clients which would be seen as invalid by the old seednodes. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3933#issuecomment-581421981
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200203/de191be7/attachment.html>


More information about the bisq-github mailing list