[bisq-network/bisq] Vote Reveal - Silent Fail (#3758)

Christoph Atteneder notifications at github.com
Mon Feb 3 15:51:12 UTC 2020


ripcurlx requested changes on this pull request.

NACK

Did you try this out?
That won't work. It still would be shown each time as you need to check if the key was set before you open the popup. Also we don't want to ask once and hide all popups afterwards, we want to show it at least once for each different transaction failure. So that means you need to extend the key with the tx id.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3758#pullrequestreview-352357375
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200203/f2c25d21/attachment.html>


More information about the bisq-github mailing list