[bisq-network/bisq] Accept old trade statistic object (#3933)
Christoph Atteneder
notifications at github.com
Tue Feb 4 09:51:59 UTC 2020
ripcurlx commented on this pull request.
> @@ -217,7 +218,7 @@ public static TradeStatistics2 fromProto(protobuf.TradeStatistics2 proto) {
proto.getTradePrice(),
proto.getTradeAmount(),
proto.getTradeDate(),
- null, // We don't want to expose this anymore
+ ProtoUtil.stringOrNullFromProto(proto.getDepositTxId()),
Yes, you only get the additionally privacy if you update or if you trade with a peer that has already updated. I had to do it like that to prevent the unnecessary load from old clients.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3933#discussion_r374570236
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200204/dad6179c/attachment.html>
More information about the bisq-github
mailing list