[bisq-network/bisq] Remove unused i18n strings (#3932)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK

@niyid Thanks for looking into this, but your code needs to take care not to remove dynamically created keys in code as well. Atm it would remove used keys at well:
- dao.param.*
- dao.phase.*
- dao.bond.bondState.*
- dao.bond.lockupReason.*
- dao.bond.bondedRoleType.*
- dao.assetState.*
- dao.proposal.type.*
- dao.tx.type.enum.*
- *_SHORT
- NOT remove # comment lines
have to be excluded as they are used in code.

Also I don't think we should put this into the source directory. Normally this kind of tools are put into the test directory so it is not included in any source build process.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3932#pullrequestreview-352865315
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200204/f4d0658b/attachment.html>