[bisq-network/bisq] Vote Reveal - Silent Fail (#3758)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK

Please see my comments. Also please rebase your PR so it is easier to test locally and I think it will remove one necessary change you did to the editorconfig file. Actually my checkstyle configuration should now catch this issues, but somehow running a recheck didn't do the trick yet.

> @@ -83,10 +79,12 @@
     private final BtcWalletService btcWalletService;
     private final P2PService p2PService;
     private final WalletsManager walletsManager;
-
+    

No empty spaces

>      @Getter
     private final ObservableList<VoteRevealException> voteRevealExceptions = FXCollections.observableArrayList();
     private final List<VoteRevealTxPublishedListener> voteRevealTxPublishedListeners = new ArrayList<>();
+    private final List<VoteRevealTxFailedListener> voteRevealTxFailedListeners = new ArrayList<>();
+    

No empty spaces

>                      .feedback(Res.get("dao.voteReveal.txPublished", txId))
                     .show();
         });
+
+        voteRevealService.addVoteRevealTxFailedListener((exception) -> {
+            String key = "showVoteRevealFailedWarnPopupOnStartup" + exception.getBlindVoteTxId();
+            if(preferences.showAgain(key)) {

`if (preferences.showAgain(key)) {` whitespace is missing after `if`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3758#pullrequestreview-354537825
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200206/dbca1fbd/attachment.html>