[bisq-network/bisq] Validate ignored peers and BTC nodes (#3895)

wiz notifications at github.com
Sun Feb 9 11:31:23 UTC 2020


wiz commented on this pull request.



> +        assertTrue(regexValidator.validate("qrstuvwxyzABCDEF.onion,qrstuvwxyzABCDEF.onion,aaaaaaaaaaaaaaaa.onion").isValid);
+        assertTrue(regexValidator.validate("GHIJKLMNOPQRSTUV.onion:9999").isValid);
+        assertTrue(regexValidator.validate("WXYZ234567abcdef.onion,GHIJKLMNOPQRSTUV.onion:9999").isValid);
+        assertTrue(regexValidator.validate("aaaaaaaaaaaaaaaa.onion:9999,WXYZ234567abcdef.onion:9999,2222222222222222.onion:9999").isValid);
+
+        assertTrue(regexValidator.validate("12.34.56.78").isValid);
+        assertTrue(regexValidator.validate("12.34.56.78:8888").isValid);
+
+        assertFalse(regexValidator.validate(" ").isValid);
+        assertFalse(regexValidator.validate("abcd.onion").isValid);
+        assertFalse(regexValidator.validate("abcdefghijklmnop,abcdefghijklmnop.onion").isValid);
+        assertFalse(regexValidator.validate("abcdefghi2345689.onion:9999").isValid);
+        assertFalse(regexValidator.validate("onion:9999,abcdefghijklmnop.onion:9999").isValid);
+        assertFalse(regexValidator.validate("abcdefghijklmnop.onion:").isValid);
+        assertFalse(regexValidator.validate("32zzibxmqi2ybxpqyggwwuwz7a3lbvtzoloti7cxoevyvijexvgsfeid.onion:8333").isValid);
+

```suggestion
        assertTrue(regexValidator.validate("example.com").isValid);
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3895#pullrequestreview-355600606
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200209/061872fd/attachment.html>


More information about the bisq-github mailing list