[bisq-network/bisq] Revert setting of null to deposit tx id (#3958)

[sqrrm]

sqrrm commented on this pull request.



> @@ -150,4 +154,30 @@ private void dump() {
             jsonFileManager.writeToDisc(Utilities.objectToJson(array), "trade_statistics");
         }
     }
+
+    static class WrapperTradeStatistics2 {
+        private TradeStatistics2 tradeStatistics;
+
+        public WrapperTradeStatistics2(TradeStatistics2 tradeStatistics) {
+

```suggestion
```

> +        private TradeStatistics2 tradeStatistics;
+
+        public WrapperTradeStatistics2(TradeStatistics2 tradeStatistics) {
+
+            this.tradeStatistics = tradeStatistics;
+        }
+
+        public TradeStatistics2 unwrap() {
+            return this.tradeStatistics;
+        }
+
+        @Override
+        public boolean equals(Object obj) {
+            if (this == obj) return true;
+            if (obj == null || getClass() != obj.getClass()) return false;
+            var wrapper = (WrapperTradeStatistics2) obj;

Don't you need a check that obj is actually a `WrapperTradeStatistics2` here? Could cause an exception otherwise.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3958#pullrequestreview-355900454
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200210/3a8c085e/attachment.html>