[bisq-network/bisq] Revert setting of null to deposit tx id (#3958)

Christoph Atteneder notifications at github.com
Mon Feb 10 12:47:31 UTC 2020


ripcurlx commented on this pull request.



> +        private TradeStatistics2 tradeStatistics;
+
+        public WrapperTradeStatistics2(TradeStatistics2 tradeStatistics) {
+
+            this.tradeStatistics = tradeStatistics;
+        }
+
+        public TradeStatistics2 unwrap() {
+            return this.tradeStatistics;
+        }
+
+        @Override
+        public boolean equals(Object obj) {
+            if (this == obj) return true;
+            if (obj == null || getClass() != obj.getClass()) return false;
+            var wrapper = (WrapperTradeStatistics2) obj;

Could add it to make it safer if it is reused somewhere.
Atm using it like that should not cause this case to ever happen.
```
.map(WrapperTradeStatistics2::new)
.distinct()
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3958#discussion_r377041468
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200210/13926747/attachment.html>


More information about the bisq-github mailing list