[bisq-network/bisq] Version 1.2.7 not working with system Tor (#3987)

[agb19]

### Description
There seems to be a regression in version 1.2.7 that breaks the option to use existing Tor instead of builtin. 

#### Version
Bisq 1.2.7 - FAILS
Bisq 1.2.5 - works

OS = Tails 4.3

### Steps to reproduce
- boot up an instance of Tails 4.3 with admin password enabled
- download and install onion grater configuration (modified for this issue):
`wget https://gist.githubusercontent.com/agb19/549eb605937ccda4c12ba5f621505299/raw/c59ea445e1de8ec468590a2ce4dd5c4ac4c71e37/bisq-debug.yml`
`sudo cp -fa bisq-debug.yml /etc/onion-grater.d/`
- download and install Bisq versions 1.2.5 and 1.2.7
`wget https://github.com/bisq-network/bisq/releases/download/v1.2.7/Bisq-64bit-1.2.7.deb https://github.com/bisq-network/bisq/releases/download/v1.2.5/Bisq-64bit-1.2.5.deb`
`sudo dpkg --install Bisq-64bit-1.2.5.deb`
`sudo mv -f /opt/Bisq /opt/Bisq-1.2.5`
`sudo dpkg --install Bisq-64bit-1.2.7.deb`
`sudo mv -f /opt/Bisq /opt/Bisq-1.2.7`
- at this point, we can run the two different versions and compare the results:
  - `/opt/Bisq-1.2.5/Bisq --logLevel=INFO --torControlPort=9051`, or
  - `/opt/Bisq-1.2.7/Bisq --logLevel=INFO --torControlPort=9051`


### Expected behaviour
Versions 1.2.5 as well as 1.2.7 should start up and operate as intended.

### Actual behaviour
Version 1.2.5 starts up and runs OK.

Version 1.2.7 appears to time out connecting to system Tor.
`tcpdump` running on the loopback interface doesn't show any connection attempts to port 9051.

### Logs
```Feb-18 13:43:03.765 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: onInitP2pNetwork 
Feb-18 13:43:03.765 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: onInitP2pNetwork 
Feb-18 13:43:03.812 [NetworkNode-9999] INFO  b.n.p2p.network.RunningTor: Connecting to running tor 
Feb-18 13:43:03.816 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: walletInitialized=false, p2pNetWorkReady=false 
[... several lines concerning b.n.p.s.p.StoreService removed ...]
Feb-18 13:43:13.612 [readFromResourcesThread] INFO  bisq.core.app.SetupUtils: readFromResources took 27547 ms 
Feb-18 13:43:13.613 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: onInitP2pNetwork 
Feb-18 13:43:13.613 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: onInitP2pNetwork 
Feb-18 13:43:13.614 [JavaFX Application Thread] WARN  b.n.p2p.network.NetworkNode: Try to add a setupListener which was already added. 
Feb-18 13:43:13.625 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: walletInitialized=false, p2pNetWorkReady=false 
Feb-18 13:43:13.626 [NetworkNode-9999] INFO  b.n.p2p.network.RunningTor: Connecting to running tor 
Feb-18 13:47:03.771 [JavaFX Application Thread] WARN  bisq.core.app.BisqSetup: startupTimeout called 
Feb-18 13:47:04.216 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: Set log level for org.berndpruenster.netlayer classes to DEBUG to show more details for Tor network connection issues 
```

#### Device or machine
Tails 4.3 (Debian 10.3)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3987
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200218/0796690e/attachment.html>