[bisq-network/bisq] Version 1.2.7 not working with system Tor (#3987)

[agb19]

Hi ripcurlx, thanks for looking. Without the torControlPort argument, both 1.2.5 and 1.2.7 fail (because Tails prohibits Tor inside Tor), but they _fail in identical ways_ so it's no problem on Bisq-side. 
The only problem is when I try to use the system Tor via torControlPort. 

---

I only had limited time, but I've made one more test to isolate the issue:
`sudo strace -f -e trace=connect -u amnesia /opt/Bisq-1.2.5/Bisq --logLevel=INFO --torControlPort=9051`

I did a little cleanup on the output and pulled the following relevant snippet (note that this is a successful run of 1.2.5, showing the "expected" behaviour"):
```
strace: Process 29362 attached
[pid 29362] connect(32, {sa_family=AF_INET, sin_port=htons(8333), sin_addr=inet_addr("127.0.0.1")}, 16) = -1 EINPROGRESS (Operation now in progress)
[pid 29362] +++ exited with 0 +++
Feb-19 09:51:49.969 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: onInitP2pNetwork 
Feb-19 09:51:49.970 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: onInitP2pNetwork 
strace: Process 29365 attached
Feb-19 09:51:49.993 [NetworkNode-9999] INFO  b.n.p2p.network.RunningTor: Connecting to running tor 
Feb-19 09:51:50.003 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: walletInitialized=false, p2pNetWorkReady=false 
[pid 29365] connect(32, {sa_family=AF_INET, sin_port=htons(9051), sin_addr=inet_addr("127.0.0.1")}, 16) = 0
strace: Process 29367 attached
Feb-19 09:51:50.261 [NetworkNode-9999] INFO  b.n.p2p.network.RunningTor: 
################################################################
Connecting to Tor successful after 268 ms. Start publishing hidden service.
################################################################ 
```
There are two **connect()** calls, and from the context we understand that the first one is an attempt to probe for a Bitcoin node on the local machine port 8333, and the second one is the connection to Tor's control port (supplied via command-line as 9051). The software works correctly.

When I repeat the test with version 1.2.7, I see the first connect() call to port 8333, however after the message "Connecting to running tor" `strace` shows **no connect() call** - to port 9051 or any other. The timeout occurs 4 minutes later. 

This is consistent with my observation from running tcpdump on loopback, and confirms that the issue is located within the Bisq app (not a firewall issue etc). 

I hope this helps, and provides a portable test to reproduce the bug even on non-Tails Linuxes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3987#issuecomment-588170219
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200219/70802ea5/attachment.html>