[bisq-network/bisq] Add pricenode one-command installer script, systemd service, README (#3997)

Florian Reimair notifications at github.com
Sat Feb 22 11:26:50 UTC 2020


freimair commented on this pull request.

NACK

- the config for the JVM heap monitoring has been changed so that it constantly creates errors for pricenodes (because the jmxremote-access point is not configured)
- see comment for line 55
- 

> -sudo -H -i -u "${ROOT_USER}" systemctl restart bisq.service
+set +e

this lets errors slip through and leave operators in the believe that everything is fine.

Something like this may do it. I am pretty sure though that if I really want to break it I still can.
```
set +e
service bisq status >/dev/null 2>&1
[ $? != 4 ] && set -e && sudo -H -i -u "${ROOT_USER}" systemctl restart bisq.service
set +e
service bisq-pricenode status >/dev/null 2>&1
[ $? != 4 ] && set -e && sudo -H -i -u "${ROOT_USER}" systemctl restart bisq-pricenode.service
set -e
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3997#pullrequestreview-363024124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200222/5ed42652/attachment.html>


More information about the bisq-github mailing list