[bisq-network/bisq] Add pricenode one-command installer script, systemd service, README (#3997)

Florian Reimair notifications at github.com
Mon Feb 24 14:07:12 UTC 2020


freimair requested changes on this pull request.

sry. Thought it is good enough, However, having a hard-coded version in the service file seems off.

What do you guys think? @cbeams?

> @@ -0,0 +1,21 @@
+[Unit]
+Description=Bisq Price Node
+After=network.target
+
+[Service]
+EnvironmentFile=/etc/default/bisq-pricenode.env
+ExecStart=/usr/bin/java -jar /bisq/bisq/lib/pricenode-0.7.2-SNAPSHOT.jar 2 2

Is there a specific reason not to use the start script `/bisq/bisq/bisq-pricenode` for the price node?

As there is a specific version hard coded in the service file seems like we might risk missing updating the bisq.service file and thus, producing maintenance issues and efforts.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3997#pullrequestreview-363410568
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200224/6c87d617/attachment.html>


More information about the bisq-github mailing list