[bisq-network/bisq] Add pricenode one-command installer script, systemd service, README (#3997)
notifications at github.com
Mon Feb 24 14:10:47 UTC 2020
The current pricenode version is BS in any case. It's an artifact of the pricenode having been formerly split off into a separate repository. Agree that the version should not be hard coded in the installer in any case. The version should be the same as the rest of Bisq (as it is versioned with Bisq). That change is out of scope here, just mentioning it. As far as using the `bisq-pricenode` script, I don't see any reason not to, but again, I'm not really familiar with what's going on in this PR. Would leave it to @wiz to say.
> On Feb 24, 2020, at 3:06 PM, Florian Reimair <notifications at github.com> wrote:
> @freimair requested changes on this pull request.
> sry. Thought it is good enough, However, having a hard-coded version in the service file seems off.
> What do you guys think? @cbeams <https://github.com/cbeams>?
> In pricenode/bisq-pricenode.service <https://github.com/bisq-network/bisq/pull/3997#discussion_r383282433>:
> > @@ -0,0 +1,21 @@
> +Description=Bisq Price Node
> +ExecStart=/usr/bin/java -jar /bisq/bisq/lib/pricenode-0.7.2-SNAPSHOT.jar 2 2
> Is there a specific reason not to use the start script /bisq/bisq/bisq-pricenode for the price node?
> As there is a specific version hard coded in the service file seems like we might risk missing updating the bisq.service file and thus, producing maintenance issues and efforts.
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/bisq-network/bisq/pull/3997?email_source=notifications&email_token=AACJV4THEN7CCTTMQXFF3HDREPH77A5CNFSM4KZB4VH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWUTJCA#pullrequestreview-363410568>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACJV4W3TD3JRYAUW63UUS3REPH77ANCNFSM4KZB4VHQ>.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github