[bisq-network/bisq] Add and rename Portfolio History columns meaningfully. (#3785)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK

Please see my comments and also please rebase against master to make it easier to review. Thanks!

> +        makerMiningFeeColumn.setComparator(new Comparator<ClosedTradableListItem>() {
+            @Override
+            public int compare(ClosedTradableListItem o1, ClosedTradableListItem o2) {
+                return model.getMakerMiningFee(o1).compareTo(model.getMakerMiningFee(o2));
+            }
+        });

This can be done within one line
```
makerMiningFeeColumn.setComparator(Comparator.comparing(model::getMakerMiningFee));
```

> +        takerMiningFeeColumn.setComparator(new Comparator<ClosedTradableListItem>() {
+            @Override
+            public int compare(ClosedTradableListItem o1, ClosedTradableListItem o2) {
+                return model.getTakerMiningFee(o1).compareTo(model.getTakerMiningFee(o2));
+            }
+        });

This can be done within one line
```
takerMiningFeeColumn.setComparator(Comparator.comparing(model::getTakerMiningFee));
```

> +        makerTradingFeeColumn.setComparator(new Comparator<ClosedTradableListItem>() {
+            @Override
+            public int compare(ClosedTradableListItem o1, ClosedTradableListItem o2) {
+                return model.getMakerTradingFee(o1).compareTo(model.getMakerTradingFee(o2));
+            }
+        });

This can be done within one line
```
makerTradingFeeColumn.setComparator(Comparator.comparing(model::getMakerTradingFee));
```

> +        takerTradingFeeColumn.setComparator(new Comparator<ClosedTradableListItem>() {
+            @Override
+            public int compare(ClosedTradableListItem o1, ClosedTradableListItem o2) {
+                return model.getTakerTradingFee(o1).compareTo(model.getTakerTradingFee(o2));
+            }
+        });

This can be done within one line
```
takerTradingFeeColumn.setComparator(Comparator.comparing(model::getTakerTradingFee));
```

> +    String isBuyerMakerAndSellerTaker(ClosedTradableListItem item) {
+        if (item == null)
+            return "";
+        Tradable tradable = item.getTradable();
+        boolean flag = false;
+        if (tradable.getOffer() != null) {
+            flag = tradable.getOffer().isMyOffer(keyRing);
+            return flag ? Res.get("shared.maker", tradable.getOffer().getCurrencyCode()) : Res.get("shared.taker", tradable.getOffer().getCurrencyCode());
+        } else {
+            return "";
+        }
+    }
+

This method is never used.

>          super(dataModel);
         this.accountAgeWitnessService = accountAgeWitnessService;
         this.formatter = formatter;
+        this.keyRing = keyRing;

Is never used

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3785#pullrequestreview-364819404
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200226/f000072e/attachment.html>