[bisq-network/bisq] Add local Bitcoin node configuration detection (#3982)

dmos62 notifications at github.com
Wed Feb 26 12:21:56 UTC 2020


> NACK
> 
> Please see my remarks in the code.
> 
> I tested the functionality on Regtest with a local Bitcoin Core and I don't get the informational popup anymore when running the client with a properly configured client
> ![Bildschirmfoto 2020-02-26 um 11 29 59](https://user-images.githubusercontent.com/170962/75336389-5b14a700-588b-11ea-927e-3b71ee4d763c.png)
> Having peer bloom filters not configured and I also don't get the warning. Doesn't it work with the local Regtest setup?

Yes, if below expression evaluates to true, a local Bitcoin node is ignored:

```
config.ignoreLocalBtcNode
    || baseCurrencyNetwork.isDaoRegTest()
    || baseCurrencyNetwork.isDaoTestNet()
```

I didn't introduce this, though I centralized this logic, because it was repeated in several places around the codebase.

The "Background information" popup shouldn't be shown if you have bloom filters set to 1. That's weird. It is currently configured to show when a well configured local BTC node is found (::isUsable()).

I retested in mainnets and both pruning and disabled bloom filters are detected. I'll try and replicate your setup to see if I can understand what's happening.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3982#issuecomment-591398704
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200226/76fc518f/attachment.html>


More information about the bisq-github mailing list