[bisq-network/bisq] Add local Bitcoin node configuration detection (#3982)

[dmos62]

 @ripcurlx Pushed changes, including a major fix. I was probably wrong about why detection failed for you.

I was unable to replicate what you experienced. There was a bug preventing detection from working on other `baseCurrencyNetwork`s than mainnet, but it didn't seem to affect you. You managed to handshake with a regtest btc node and not get it detected as having bloom filters disabled. That should have been impossible for at least two reasons. I may have misunderstood what your setup was. I tested (successfully) with mainnet (no params to Bisq) and with following params (from dev-setup.md):

```
--baseCurrencyNetwork=BTC_REGTEST --useLocalhostForP2P=true
--useDevPrivilegeKeys=true --nodePort=5555 --appName=bisq-BTC_REGTEST_Alice
```
and `regtest=1` in bitcoin.conf.

Could you provide the Bisq arguments you used and the Bitcoin Core config as well?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3982#issuecomment-591520259
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200226/dbd3087c/attachment.html>