[bisq-network/bisq] Add local Bitcoin node configuration detection (#3982)

[Chris Beams]

I suggest disengaging from style discussions at this point. If the substantive changes in this PR are otherwise ACK-worthy, then merge it, and someone can issue a follow-up PR correcting the deviations. It’ll be faster that way. I’ll do it myself, even.

Alternatively, one of the maintainers could push those changes against the current PR branch, but it’s probably better in this situation to have a separate PR that documents the rework necessary.

@dmos, thanks for your contributions, but in a large established codebase like Bisq, a contributor’s goal should be to produce stylistically perfect patches, where perfect is defined by not causing reviewers to digress into style discussions or needing to clean up after you.

It takes some time to catch up with the nuances of style conventions in any large codebase and Bisq is far from perfectly consistent with its own conventions. As such, it’s expected that newcomers will make mistakes here and there; that’s not a problem. The main thing is to strive for patches that require as little overhead as possible for reviewers and maintainers, and style quibbles are overhead.

>> On Feb 26, 2020, at 8:10 PM, dmos62 <notifications at github.com> wrote:
> 
> @dmos62 commented on this pull request.
> 
> In core/src/main/java/bisq/core/btc/nodes/LocalBitcoinNode.java:
> 
> > +                            var mayInterruptWhileRunning = true;
> +                            peerVersionMessageFuture.cancel(mayInterruptWhileRunning);
> @sqrrm the reason why I use these is to not have "anonymous" values in calls. Example: buildHouse(false) v. buildHouse(withRoof).
> 
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3982#issuecomment-591606090
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200226/bdab520a/attachment.html>