[bisq-network/bisq] Bisq does not update onion address of offers after deleting Tor data (#3995)

[Florian Reimair]

Looked into it and these are the results:

## I am having a hard time reproducing the issue.

Settings -> Network Info -> Open Tor Settings -> "Delete outdated Tor files and restart" does not delete the hidden service files. it only cleans up around them.

see for reference
https://github.com/bisq-network/bisq/blob/1d1cba1e4df6a3aaa2821f599b363bfbcf43de48/core/src/main/java/bisq/core/app/TorSetup.java#L61

This piece of code btw gets called on every application start:
 - if there is an issue it would show every time an application gets started with offer already opened
 - renders the "Delete outdated Tor files and restart" button kind of useless

## If you manually delete the files
However, I agree that when you manually delete the `.../hiddenservice` directory, then everything you say is true.

## Questions

- There seems to be now way of getting into the situation you described by doing the steps you provided. Is there anything special about your setup?

- Furthermore, shall we fix the behavior if someone tempers with the tor directory manually? is this a common practice to suggest this in support?


<details><summary>Testing environment</summary>

I tried to reproduce the thing using
- master build 
- tag v1.2.7

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3995#issuecomment-592480901
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200228/a72fe950/attachment-0001.html>