[bisq-network/bisq] Improve handling of spv resync edge case (#3821)

sqrrm notifications at github.com
Thu Jan 2 11:03:46 UTC 2020


sqrrm approved this pull request.

utACK

This will likely lead to fewer trades moved to failed trades when they shouldn't be.

A point on invalid txs; some txs, such as those with 0 miner fee, are valid and could be mined. It's just very unlikely that they would be. In Bisq's case it's clear they won't be mined, but in the case when fees go up and bitcoin nodes with the default mempool size kick low fee txs out but other nodes with larger mempools keep them it's not quite clear which txs are going to confirm later and which won't.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3821#pullrequestreview-337613201
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200102/35e2f16a/attachment-0001.html>


More information about the bisq-github mailing list