[bisq-network/bisq] Improve readability of the daily burnt BSQ chart (#3890)

dmos62 notifications at github.com
Sat Jan 11 21:04:51 UTC 2020


Relevant issue: #3753 

These commits are about improving readability of the daily burnt BSQ chart. It is done by introducing a 'Zoom to inliers' toggle, which when active zooms in on inliers, and by introducing a moving average. The zooming feature is automatic and should be at least somewhat robust to new trends. The moving average contextualizes the large peaks and gullies and generally improves interpretability of this noisy series. Also, the charts' Y axes are set to include 0, most notably in the monthly issued BSQ chart.

I have provided details in the commit messages.

The numerous changes to the SupplyView class are contained in a single commit, which I realise is not comfortable to review. Ideally I would have refactored in a separate commit, but I wasn't sure how I want to refactor until many of the changes were already implemented.

Below are screenshots illustrating changes to the daily burnt BSQ chart:

This is before changes:
![bsq burnt before changes](https://user-images.githubusercontent.com/2715476/72210393-56ef1e80-34c3-11ea-95da-a09db5df1ede.png)
This is a GIF slideshow (2 frames) of the zoom toggle being toggled in the new chart:
![bsq burnt after changes animation](https://user-images.githubusercontent.com/2715476/72210450-6b7fe680-34c4-11ea-8d52-bb7f124dd579.gif)

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3890

-- Commit Summary --

  * Provide an online standard deviation algorithm
  * Provide a way to zoom a chart axis to inliers
  * Provide an online moving average algorithm
  * Improve readability of the daily burnt BSQ chart

-- File Changes --

    A common/src/main/java/bisq/common/util/DoubleSummaryStatisticsWithStdDev.java (87)
    M core/src/main/resources/i18n/displayStrings.properties (2)
    M desktop/src/main/java/bisq/desktop/bisq.css (7)
    M desktop/src/main/java/bisq/desktop/main/dao/economy/supply/SupplyView.java (323)
    A desktop/src/main/java/bisq/desktop/util/AxisInlierUtils.java (323)
    A desktop/src/main/java/bisq/desktop/util/MovingAverageUtils.java (136)
    A desktop/src/test/java/bisq/desktop/util/MovingAverageUtilsTest.java (172)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3890.patch
https://github.com/bisq-network/bisq/pull/3890.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3890
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200111/006cd160/attachment-0001.html>


More information about the bisq-github mailing list