[bisq-network/bisq] Redact DepositTxId when publishing TradeStatistics for user privacy (#3891)

wiz notifications at github.com
Sat Jan 11 23:46:00 UTC 2020


Before:
```
  { 
    "currency": "JPY",
    "direction": "SELL",
    "tradePrice": 8791986900,
    "tradeAmount": 10000,
    "tradeDate": 1578784489588,
    "paymentMethod": "F2F",
    "offerDate": 1578784398352,
    "useMarketBasedPrice": true,
    "marketPriceMargin": 0.0,
    "offerAmount": 10000,
    "offerMinAmount": 10000,
    "offerId": "12635-224f7143-3366-46e7-9e14-7fa6f39fcb2b-125",
    "depositTxId": "9c67453e57cfc80e2c121caf54f8f739cef6c5d7e9afdceec7843436a920f9d8",
    "currencyPair": "BTC/JPY",
    "primaryMarketDirection": "SELL",
    "primaryMarketTradePrice": 87919869000000,
    "primaryMarketTradeAmount": 10000,
    "primaryMarketTradeVolume": 8791980000
  },
```

After:
```
  {
    "currency": "JPY", 
    "direction": "SELL",
    "tradePrice": 8791986900,
    "tradeAmount": 10000, 
    "tradeDate": 1578784489149,
    "paymentMethod": "F2F", 
    "offerDate": 1578784398352,
    "useMarketBasedPrice": true,
    "marketPriceMargin": 0.0,
    "offerAmount": 10000, 
    "offerMinAmount": 10000, 
    "offerId": "12635-224f7143-3366-46e7-9e14-7fa6f39fcb2b-125",
    "depositTxId": "0000000000000000000000000000000000000000000000000000000000000000",
    "currencyPair": "BTC/JPY",
    "primaryMarketDirection": "SELL",
    "primaryMarketTradePrice": 87919869000000,
    "primaryMarketTradeAmount": 10000, 
    "primaryMarketTradeVolume": 8791980000
  },
```
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3891

-- Commit Summary --

  * Redact DepositTxId when publishing TradeStatistics for user privacy

-- File Changes --

    M core/src/main/java/bisq/core/trade/protocol/tasks/PublishTradeStatistics.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3891.patch
https://github.com/bisq-network/bisq/pull/3891.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3891
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200111/98ba37cf/attachment.html>


More information about the bisq-github mailing list