[bisq-network/bisq] Validate ignored peers and BTC nodes (#3895)

Devin Bileck notifications at github.com
Mon Jan 13 07:15:12 UTC 2020


In addition to adding input validation for ignored peers and BTC nodes, this PR also fixes #3137.

Since with input validation the user is no longer able to enter an invalid BTC host, to verify #3137 start the app with the following option:
`--btcNodes=32zzibxmqi2ybxpqyggwwuwz7a3lbvtzoloti7cxoevyvijexvgsfeid.onion:8333`

You will be presented with the following:
![image](https://user-images.githubusercontent.com/603793/72237522-9daa4a80-358f-11ea-8921-00587fa26da7.png)

After shutting down the app, restart it without the previous option and observe the BTC config. You will see the invalid custom BTC config but it will be using the provided BTC nodes.

![image](https://user-images.githubusercontent.com/603793/72237696-4193f600-3590-11ea-87ff-884778a6ab96.png)



You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/3895

-- Commit Summary --

  * Allow setting validation error message for InputTextField
  * Add input validation for ignored peers and BTC nodes
  * Suppress shutdown popup when BTC nodes have not changed
  * Allow for selecting custom BTC nodes on testnet
  * Capitalize connection failed string
  * Revert to using provided BTC nodes if custom nodes are invalid

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqHeadlessApp.java (1)
    M core/src/main/java/bisq/core/app/BisqSetup.java (10)
    M core/src/main/java/bisq/core/app/WalletAppSetup.java (10)
    A core/src/main/java/bisq/core/btc/exceptions/InvalidHostException.java (25)
    M core/src/main/java/bisq/core/btc/setup/WalletsSetup.java (23)
    M core/src/main/resources/i18n/displayStrings.properties (4)
    M desktop/src/main/java/bisq/desktop/components/InputTextField.java (35)
    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (10)
    M desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.java (90)
    M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (9)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (11)
    M desktop/src/main/java/bisq/desktop/util/validation/JFXInputValidator.java (6)
    M desktop/src/test/java/bisq/desktop/util/GUIUtilTest.java (31)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/3895.patch
https://github.com/bisq-network/bisq/pull/3895.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3895
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200112/67354982/attachment-0001.html>


More information about the bisq-github mailing list