[bisq-network/bisq] Vote Reveal - Silent Fail (#3758)
Christoph Atteneder
notifications at github.com
Mon Jan 13 14:40:50 UTC 2020
ripcurlx requested changes on this pull request.
NACK - Please see my comment. Would also be great if you could rebase your PR to master. Makes it easier for testing using the most up-to-date codebase.
> @@ -252,6 +261,9 @@ private void revealVote(MyVote myVote, boolean isInVoteRevealPhase) {
} catch (VoteRevealException e) {
voteRevealExceptions.add(e);
}
+
Unnecessary spaces that popped up when I auto-re-formatted your code.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3758#pullrequestreview-341889413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200113/d9940950/attachment.html>
More information about the bisq-github
mailing list