[bisq-network/bisq] Add and rename Portfolio History columns meaningfully. (#3785)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - Because of code format issues. Please also rebase your PR against master so it is easier also to test with a mainnet client. Thanks!

> +    TableColumn<ClosedTradableListItem, ClosedTradableListItem> priceColumn, amountColumn, volumeColumn, 
+		makerMiningFeeColumn, takerMiningFeeColumn, makerTradingFeeColumn, takerTradingFeeColumn, buyerSecurityDepositColumn, 
+		sellerSecurityDepositColumn, marketColumn, directionColumn, dateColumn, tradeIdColumn, stateColumn, avatarColumn;
+    

Nearly every line in this file except the imports has issues with using the wrong spacing (not using our format style)

> @@ -20,11 +20,12 @@
 import bisq.desktop.common.model.ActivatableWithDataModel;
 import bisq.desktop.common.model.ViewModel;
 import bisq.desktop.util.DisplayUtils;
-
+import bisq.common.crypto.KeyRing;

Empty line is missing before and after this import to be in line with our imports format

> @@ -126,7 +142,22 @@ String getSellerSecurityDeposit(ClosedTradableListItem item) {
         else
             return "";
     }
-
+    

Unnecessary spaces

> +        }
+        else {
+            return "";
+        }
+    }
+    

Format issues as well. Please apply our code format style.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3785#pullrequestreview-341897371
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200113/52f087f7/attachment.html>