[bisq-network/bisq] Improve readability of the daily burnt BSQ chart (#3890)

Christoph Atteneder notifications at github.com
Thu Jan 16 15:33:30 UTC 2020


ripcurlx requested changes on this pull request.

NACK - Running `reformat code` and `optimize imports` in IntelliJ changes quite a lot in your files. Please adapt our code style.

Just for functionality your code does what it is expected to do. Could you please adapt the style of the line chart so the BSQ burnt has the same line thickness as the chart above. Atm it looks still a little bit developer style 😉 . 
![Bildschirmfoto 2020-01-16 um 16 30 56](https://user-images.githubusercontent.com/170962/72538274-e018a380-387d-11ea-8672-147dcd012e49.png)

Thanks for this contribution 👍  

> + * under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or (at
+ * your option) any later version.
+ *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.common.util;
+
+import bisq.common.util.Tuple2;

Not used in code

> + *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.common.util;
+
+import bisq.common.util.Tuple2;
+
+import java.util.DoubleSummaryStatistics;
+import bisq.common.util.DoubleSummaryStatisticsWithStdDev;

Not used in code

> +import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
+import java.util.stream.StreamSupport;
+import java.util.Spliterators.AbstractSpliterator;
+
+import java.util.function.BiFunction;
+import java.util.function.Supplier;
+import java.util.function.Consumer;
+
+import javafx.collections.ListChangeListener;
 
 import static bisq.desktop.util.FormBuilder.addTitledGroupBg;
 import static bisq.desktop.util.FormBuilder.addTopLabelReadOnlyTextField;
+import static bisq.desktop.util.FormBuilder.addSlideToggleButton;

Do you use IntelliJ for development? If yes, please use the formatting functionality that auto sorts and groups the different imports. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3890#pullrequestreview-343992540
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200116/09994fc0/attachment.html>


More information about the bisq-github mailing list