[bisq-network/bisq] Refactor option handling (#3889)
Christoph Atteneder
notifications at github.com
Fri Jan 17 14:36:01 UTC 2020
> I've just pushed fixes for the code quality issues, but a number of false positives will remain unfixed. Please see my commit comment for details. @ripcurlx, this may be an example of a PMD rule we want to eliminate. Would like to know why it's a false positive, though. Those imports are in fact used.
I just removed the unused on demand import pattern that seems to have caused the issue in the `ConfigTests` and I ignored the issues in `BisqGrpcClient` based on https://github.com/bisq-network/bisq/pull/3889#issuecomment-575646962.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3889#issuecomment-575650771
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200117/126dbc12/attachment.html>
More information about the bisq-github
mailing list