[bisq-network/compensation] For Cycle 9 (#460)

Chris Beams notifications at github.com
Fri Jan 17 16:01:21 UTC 2020

I'll vote this down as well. 900 USD for PR bisq-network/bisq#3777 seems particularly high to me, especially considering the follow up @ripcurlx had to do in review. As others have mentioned, please feel free to resubmit in the next cycle (from your comment above, it sounds like you already plan to do this).

Also @beingindot, please review the following section of the contributor guidelines: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#write-well-formed-commit-messages. A quick look at the `shortlog` output will show you how your commit messages break Git's assumptions and make reading things difficult.

$ git shortlog --author beingindot
beingindot (7):
      Added padding for flowpane to resolve moneygram save issue.
      Added check for empty validation This commit is for github issue #3458 and #3459 check added for moneybeam and national bank transfer
      Added empty check validation for popmoney/revolut/uphold/zelle
      Include bloom filter for newer bitcoin core v0.19.0.1
      Revolut account should accept only phone number For issue #3728   Till now we used to accept email or phone number
       Now we are accepting only phone number in input though  for display we will provide backward compatibility.
      creating altcoin offer not throwing error during previously set high security deposit.
      Trade limit error message is not clear    Fixes #3712

Finally, please be consistent in denominating your contribution request line items and subtotals in USD. Currently you have a mix of USD and BSQ-denominated entries, and it makes it difficult to gauge things. Ideally, everything is accounted for in USD and then converted to BSQ on the top line of the request at the current 90-day moving average rate.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200117/0400fce4/attachment.html>

More information about the bisq-github mailing list