[bisq-network/bisq] Introduce gRPC API proof of concept (#3888)
sqrrm
notifications at github.com
Mon Jan 20 12:31:34 UTC 2020
sqrrm commented on this pull request.
I'm awaiting a statement on new dependencies.
I found this PR to very pleasant to review, nicely structured and well documented.
> 'org.bitcoinj:orchid:f836325cfa0466a011cb755c9b0fee6368487a2352eb45f4306ad9e4c18de080',
'org.bouncycastle:bcpg-jdk15on:de3355b821fc81dd32e1f3f560d5b3eca1c678fd2400011d0bfc69fb91bcde85',
'org.bouncycastle:bcprov-jdk15on:963e1ee14f808ffb99897d848ddcdb28fa91ddda867eb18d303e82728f878349',
+ 'org.codehaus.mojo:animal-sniffer-annotations:92654f493ecfec52082e76354f0ebf87648dc3d5cec2e3c3cdb947c016747a53',
Is this one needed at all?
Reading at https://github.com/mojohaus/animal-sniffer it sounds like this functionality is already provided with javac
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3888#pullrequestreview-345220988
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200120/21d0ce6e/attachment.html>
More information about the bisq-github
mailing list