[bisq-network/bisq] Fix potential resource leak in AvoidStandbyModeService (#3909)

[Steven Barclay]

@stejbac pushed 115 commits.

5c02ce57669a7eee6e01143a686eeba782d65968  Introduce gRPC API proof of concept
b4ee9d33e5a95b58bdbc0b4cf2cd4c9928d32c7c  Do not strip trailing whitespace in Git diffs
65175a7f4fea2127539518ba9fdf4ed646c0459f  Remove --desktopWith{Grpc|Http}Api options for now
368f0ad7f14a35d5ac0e4da935b19c5c846ebbff  Ignore Structure101 Workspace files
f4ae5d31288437bd07c9c9f5cf16ecfce3e4a477  Revert "Apply kotlin plugin and convert one unused class to kotlin"
7595387c8e59a59e34fcf2818cfd220e083a4b75  Fix code quality issues
b1cabe3b82036b04f2ae6ac79443218719d288bc  Merge pull request #3886 from cbeams/git-tweaks
fa3fcb4a10201749a9e0ecfeef590d8d6c333503  Merge pull request #3887 from cbeams/revert-kotlin
8b30c22d6ee5a9f20c10ab3aa68343c4b79da742  Move bisq.core{=>.app}.CoreModule
29698fd58a6b7995971a1c0ae9898a4a5e7634c1  Introduce 'cli' subproject
7a718f0ed58536191858902dd9378a721b8c48c0  Move grpc generation from :grpc to :core
07d98a3aba96b3224c9c19070fe7ee690c941682  Move bisq.{grpc.BisqGrpcClient=>cli.BisqCliMain}
eaad2e0a4c4bf943db1b14a3da6f71b494fa6d7b  Clean up protobuf/grpc config and dependencies
aff760514b112115c8b81da768a126cab720dbbb  Sever dependency from :desktop => :grpc
900c13ef8f47f4a17087a2cac6cd1139fdd584bc  Rename submodule grpc => daemon
9fceba63e2e65a88cd39b079c3da525f9db01129  Remove duplicate attempt to start BisqGrpcServer
1e8633b03be9085b6bdd05886066aca9e632cade  Organize io.grpc imports correctly
d77ff101fbccda8ea3262fe41e53ded49d6b1bd6  Reflect higher security deposit in placeOffer RPC comment
2a66d11cd3cfc56a4ba33003dc2e25635d940e36  Exclude unnecessary dependency on animal-sniffer-plugin
92466f96eb9ea1c88419b961a364318a8755d377  Merge pull request #3888 from cbeams/grpc-poc
b34d59c0a930e436b0b542114c48005ff857d4c8  Introduce Config as replacement for BisqEnvironment
cdaa901a298841c5613fc60fb0d1d981565578d3  Move 'referralId' option handling from BisqEnvironment to Config
70bdccb258546611332d50871f9dd12084a1d59c  Move 'useDevMode' option handling from BisqEnvironment to Config
f3e0b853db2f0d3dc39a3cf0201a2af27706415f  Move 'btcNetworkDir' and co from BisqEnvironment to Config
f029fea3866b4f6e2338077108615ab427abaa4f  Move 'useDevPrivilegeKeys' option handling from BisqEnvironment to Config
6c1ef5921c415967f9c5211f05681aff84aadea2  Remove BisqException parser calls for options already moved to Config
e2781c16c5e29dc3b87f47fc2945ec81281306e0  Move 'dumpStatistics' option handling from BisqEnvironment to Config
ceac8bb9e22351077d5a75bc9cbc68678b2dc816  Finish moving baseCurrencyNetwork option handling to Config
a19410764689a6a59a283e6a8b8b50c805c8687f  Finish moving 'appDataDir' option handling to Config
e0766af5d05772347cb5700243ad74651d15ab2b  Finish moving 'userDataDir' option handling to Config
1842c47b2bf9934e288aa8ab74e3b6f1c728b630  Remove long-unused core.btc.UserAgent class
6a20013c77de7dbe4fc5233d3c95cc45f6409574  Finish moving 'appName' option handling to Config
849bd7c286fe2f6e2aadc5835340dca19b50f9e3  Move 'maxMemory' option handling to Config
13db7672a6e1c674c90d51f288de765273d620d0  Remove unused 'desktopWithHttpApi' option handling
051c53278e79e5f7ac0d73b975eed9ad5255e27b  Move 'ignoreDevMsg' option handling to Config
a720475871fbc5c3daefbaecde8cfbc70fdf4bc3  Move 'providers' option handling to Config
a2f5d5a77a8a2245ebd002eb0e6b3b28af89a3dc  Remove now unused AppOptionKeys class
f6319fe66f279dd72eac377072398fc8ae25997e  Finish moving 'logLevel' option handling to Config
7be2ff19f844d8ae00684eaa5c25deb5acede8bb  Remove now unused CommonOptionKeys class
e118165e9a05aaed99fdb023edd1d2fd799def6c  Move 'seedNode' option handling to Config
c56c06d939a21d8cbdb475a32ac55b9be0e27703  Move 'banList' option handling to Config
ef7196ef8aca2a75561560fb9450d9baff8fee75  Finish moving 'nodePort' option handling to Config
0e48a3ef2c773540db5844b454bac5580e9e97ed  Move 'useLocalhostForP2P' option handling to Config
8d6dbad484499c296d65e413864bb7b8e53cea07  Move 'maxConnections' option handling to Config
5c02b120438341cc8b110445abb3a34b886b4698  Move 'socks5ProxyBtcAddress' option handling to Config
5a0683e9849b34e4dcd3c8835e7426f59be362ff  Move 'socks5ProxyHttpAddress' option handling to Config
fea3a641c0cfbb4731d9a1d41e8784b5bf54fa45  Move 'torrcFile' option handling to Config
923ec69966f8d6d1c83b6f6befff0b8cdf47bfe2  Move 'torrcOptions' option handling to Config
d25ad0d266bb197eb53770b7a007893428d1c048  Move 'torControlPort' option handling to Config
5966d0ddcbc3e825252b2e325b34d8c3dcf9d7fd  Move 'torControlPassword' option handling to Config
e90b2566a94a7739c8b5e8e8391ac050bc0c871b  Move 'torControlCookieFile' option handling to Config
25604c1b296fd9090f93599d5ed8794e7ba6411b  Move 'torControlUseSafeCookieAuth' option handling to Config
ca3719a13963049d85620ed7132251188ef16108  Move 'torStreamIsolation' option handling to Config
2dbd72b358e1f600d8bdfbf7486414bc3673f447  Move message throttle option handling to Config
3002b16776aaa29aa58ce18ab5070b242e98808e  Make defaultUserDataDir field a local variable
8e4107d80ad535facd9f3f9705852d839f56a19d  Remove obsolete NETWORK_ID option key
326375e4e4bef5b8ff3dd6e346d9de8783ab8102  Remove now unused NetworkOptionKeys class
be971904158afbaf0224196b39d2b0226a08bee3  Rename Config.{NULL_INT=>DEFAULT_INT} for clarity
769c62b7b341354fe2e27e3d0f86026922ffb5dc  Finish moving 'bitcoinRegtestHost' option handling to Config
85285890d193f29b1f0a764bc1a06a25a906706c  Move Config.log declaration
4fb60a33ac7b6d46b197201fd7c614b6d9eaaa2a  Finish moving 'ignoreLocalBtcNode' option handling to Config
5271d4d574a199117925586e71611632c77b5c37  Move 'btcNodes' option handling to Config
90031543b9b9cdbf378dad55c8f0ebfa81a0843b  Move 'useTorForBtc' option handling to Config
b7889dd994d86f18711950fdd532bf890ad7fb0d  Move 'socks5DiscoverMode' option handling to Config
97cafaf61e9c2f47955d9ba7cef16698e8d72a1a  Move 'useAllProvidedNodes' option handling to Config
c8d739ded5d3b5e72baec9f5ca74749a56bab8c1  Move 'userAgent' option handling to Config
99cf8c9596946fb19840fc0e66615c3d6d3ad037  Move 'numConnectionsForBtc' option handling to Config
919c58eefe2aeaa9aa369c217f54ec827bd1bcb4  Remove now unused BtcOptionKeys class
80754ed3d52bd8fb639a2740cd395c9405e08ba4  Move 'rpcUser' option handling to Config
b4d4ca4fbe1d19a5763584a933c463aeb6b6e48b  Move 'rpcPassword' option handling to Config
182f47239488420786953a7e819a76424f4ea964  Move 'rpcHost' option handling to Config
86e1ae1008e07c130f0d3c81cd508ef22ab2d699  Move 'rpcPort' option handling to Config
3841e6b1ddaefdeb9628dafe1697d51c6fdba0ee  Move 'rpcBlockNotificationPort' option handling to Config
9a7eedb250cdde636f4cb8e91568b91c2ce6daf5  Move 'rpcBlockNotificationHost' option handling to Config
2995bc27bd1c6ab2726dd00ea4dacd2b1e0f5f75  Move 'dumpBlockchainData' option handling to Config
519259b752999eb5cd3b4334499fe9b8cb90f6df  Move 'fullDaoNode' option handling to Config
6ea146444f9e9cb02d8cc55960ca7b96667b8235  Move 'genesisTxId' option handling to Config
ca5b260806480ac5821cb04df2c0ff11da7048e2  Move 'genesisBlockHeight' option handling to Config
aadf7c76aa48c4050a280458784b298e6b78ed7b  Move 'genesisTotalSupply' option handling to Config
15c492b5b4c044d3c6a768d9764987681075f724  Finish moving 'daoActivated' option handling to Config
43fb85151444c1e2b5ac2dfc013f5bf7ef13ffd8  Remove now unused DaoOptionKeys class
9ff6dd2c828b153d74333701d615ee9a3e0b89b2  Finish moving 'useDevPrivilegeKeys' option handling to Config
c6d042568a26dad2d3cde8ff685f65f77d9486f2  Finish moving 'useDevMode' option handling to Config
1216ba2e2cf33bbb3f5d5ea087e696c66e7a188e  Finish moving 'referralId' option handling to Config
f5a18547626170f5d88363ab01a151c83522c860  Remove now unused BisqEnvironment class
2c7829948ba4812dc2b6cade68e181c098890b20  Replace uses of Spring CollectionUtils
51a0e66ab63195256821f013ae35224a231dc57f  Replace use of Spring's AnnotationUtils
658df7968ed7bd0c2596544baeb7cfff7845f6f4  Replace use of Spring's ClassUtils
75ab51de1af3913e92467fdf5276659d0a6e42c9  Replace use of Spring's StringUtils
c968ddf034e85ce8df367a99e7e1e002447c8106  Eliminate dependency on Spring Framework
6d6d41b32908f4c176d1e00b031c77eb88d9fad9  Broaden BisqExcutable exception handling
022b5f190860240944a0ff98c4f052b361224167  Make ConfigException extend BisqException
73823446182163e3fa53e650e4fa2b8cd7e747c1  Catch ConfigException as contingency, Throwble as fault
3f605f873ff656b22108a9dc10aea5b265cfff3f  Remove now unused BisqExecutable option handling
b5503a5aa412deb108eeb4bf0a473f786a435ef8  Replace HelpRequested exception with Config.isHelpRequested()
47794174a19dddd6a6e67b0622412cf7055b6148  Remove ConnectionConfig console output
e67746b0a4b04dd72f35732065a29398caf39e11  Remove TestConfig in favor of reworked Config ctors
a02eea9410ddeb2cb0a58131d72ca06636a60644  Extract Config.APP_DATA_DIR constant
174d2a98e6697dd8b17e74726c41518e57a50a15  Add comments to Config and reorder a few things
3a6b0ce9d886c3347b1182e7971d2075a1599c5a  Normalize creation of appDataDir and subdirs
42a037e19f6f568cfb62cb2a8a44e1e439500a80  Introduce and document static Config.baseCurrencyNetwork()
4ea329060840c0c51833042af32232fdb23703b3  Introduce and document static Config.appDataDir()
876b91e1be0002d2e214da294741d7d3d2baf20a  Introduce LocalBitcoinNode and tests
94603768cb10c786cd8e0ddad5f736f9eddb751b  Move Config.getOsUserDataDir to BisqExecutable.osUserDataDir
e1f54e95b12a9502002c136b202612b5e77c2465  Rename and reorder test for nonexistent --configFile
3d991e009a46765999c50baed0b04997d7f0e7ad  Qualify relative --configFile value with appDataDir
63489c13f25c48c6ad7110762d13349001d0c39f  Throw if --configFile value does not exist
fe506098af055aa05596a552772afab17be89419  Introduce Config testing facilities
d5abc97b049b854a62dd5e957f80350b40569dab  Document Config and related types
4ac46e47178607c27405941c1eca7231441ff90f  Reorder a few of the most important options
37b669c710888497c6b884d7bd747858131ef858  Make Config option fields public and inline accessors
efba97581359eba485d074b4b7a715d7851f1f82  Avoid race condition in LocalBitcoinNodeTests
dd5690fe2ad24b1d5d2ddd80652fa3c2d35d3248  Fix code quality issues
d4e566f6e7b49ea2a9b1f7f2ead1940ba165b769  Merge pull request #3889 from cbeams/refactor-option-handling
a073dbf13b58a5786591e493d62408d17d6b1df4  Fix potential resource leak in AvoidStandbyModeService


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/3909/files/d6d23cc4306077150064f8c0a5095546d529960c..a073dbf13b58a5786591e493d62408d17d6b1df4
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200122/0662e44b/attachment-0001.html>