[bisq-network/bisq-website] Add Lazy Loading to images and iframes (#331)
Steve Jain
notifications at github.com
Mon Jan 27 05:15:46 UTC 2020
m52go requested changes on this pull request.
To be honest, I don't see a difference in the way images are loaded, and browser support isn't great, but I don't see a downside either.
Please double-check that spacing is good throughout...I spotted 1 error.
> @@ -6,9 +6,9 @@
<div class="col-12 col-lg-4 mt-md-0 mt-3 pl-md-5 pl-sm-3 small px-sm-4 px-4">
<h5 class="text-uppercase small grey">Bisq mobile notification App</h5>
- <a target="_blank" rel="noopener" class="app-link" href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq"><img class="badge-img" alt="Get it on Google Play" src="/images/badge_google_play.svg"/></a>
+ <a target="_blank" rel="noopener" class="app-link" href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq"><img class="badge-img" alt="Get it on Google Play" src="/images/badge_google_play.svg"loading="lazy"/></a>
```suggestion
<a target="_blank" rel="noopener" class="app-link" href="https://play.google.com/store/apps/details?id=com.joachimneumann.bisq"><img class="badge-img" alt="Get it on Google Play" src="/images/badge_google_play.svg "loading="lazy"/></a>
```
Missing space.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/331#pullrequestreview-348442671
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200126/9931661c/attachment.html>
More information about the bisq-github
mailing list