[bisq-network/bisq] Vote Reveal - Silent Fail (#3758)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

NACK - Please see my comment

>      @Getter
     private final ObservableList<VoteRevealException> voteRevealExceptions = FXCollections.observableArrayList();
     private final List<VoteRevealTxPublishedListener> voteRevealTxPublishedListeners = new ArrayList<>();
-
-    ///////////////////////////////////////////////////////////////////////////////////////////
-    // Constructor
-    ///////////////////////////////////////////////////////////////////////////////////////////
-
+    private final List<VoteRevealTxFailedListener> voteRevealTxFailedListeners = new ArrayList<>();

NACK - You have to add  an empty line before the @Inject to apply our style guide.  I would have pushed this fix myself, but it seems to be that you are not allowing maintainers to push to your PR. Also please create a PR next time based on a separate branch and not directly from your master branch. Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/3758#pullrequestreview-349987002
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200129/04438649/attachment-0001.html>