[bisq-network/bisq] Limit MaxRAM for all java apps (#4186)

Stan notifications at github.com
Wed Jul 1 14:56:02 UTC 2020


> Is there some kind of conclusion to what we should do here?

My 2 sats:  I think the riskiest aspect of this change was adding the `MaxRAM` setting to `bisq-desktop`.  Since being tried out by devs and end users of the released change:
* Chris reported 1 `:desktop` OOME some months ago.
* I saw one after running a `:desktop` instance for a ~week on a 10+ year old 8 Gb Dell server.  My OOME happened while resident memory was still < 2 Gb, so I can't be sure it was due to the 4g MaxRAM setting.

That's 2 OOMEs that I know of being reported since the change has been in use by Linux/OSX devs and users, and not enough to warrant backing out the prior `MaxRAM` setting in `:desktop`.

My conclusion for this PR:  JavaFX's appetite is why the change was needed, so I'm now in favor of letting this PR go stale unless others want to see it merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4186#issuecomment-652468241
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200701/dc90927e/attachment-0001.html>


More information about the bisq-github mailing list