[bisq-network/bisq] [WIP] Add API test harness for Linux (#4366)
Stan
notifications at github.com
Mon Jul 13 22:49:08 UTC 2020
@ghubstan commented on this pull request.
> + 5122,
+ -1),
+ bobdaemon("bisq-BTC_REGTEST_Bob_dao",
+ "bisq-daemon",
+ "\"-XX:MaxRAM=2g -Dlogback.configurationFile=apitest/build/resources/main/logback.xml\"",
+ BisqDaemonMain.class.getName(),
+ 8888,
+ 5123,
+ 9999),
+ bobdesktop("bisq-BTC_REGTEST_Bob_dao",
+ "bisq-desktop",
+ "\"-XX:MaxRAM=4g -Dlogback.configurationFile=apitest/build/resources/main/logback.xml\"",
+ BisqAppMain.class.getName(),
+ 8888,
+ 5123,
+ -1);
Limiting RAM for `bisq-apitest` was not necessary -- and removed from the `bisq-apitest` script -- because it is a headless app. But we need to limit RAM for `:desktop` apps started by `bisq-apitest`, like we do for the Linux Bisq UI.
Above, you mentioned:
>> Is this to do with bisq using too much RAM in some cases? But wasn't that only relevant for long-running processes?
The Bisq UI is using too much without this limit, especially when starting it on an empty datadir. This is why `BisqAppConfig` has a larger limit for `bobdesktop` than `bobdaemon`. It's not really necessary for daemons at this stage, but it might be useful for profiling long running tests in the future.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4366#discussion_r453990776
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200713/6b8683f4/attachment-0001.html>
More information about the bisq-github
mailing list