[bisq-network/bisq] Add API test harness for Linux (#4366)

dmos62 notifications at github.com
Wed Jul 22 14:32:31 UTC 2020


@dmos62 approved this pull request.

ACK.

We had a lot of back and forth over this PR. At 3k lines the PR isn't small. Part of the complexity is the shell-level interaction between bitcoind, bitcoin-cli and Bisq daemons. I had some reservations about doing everything in Java, since that required implementing shell-type functionality. I was floating an idea to use Java routines for things that require Java API access and Bash routines for the rest (like setup, teardown and e2e tests), hoping that that would cut down on the boilerplate (and would be possible at all). I wrote up a [Bash e2e testing harness](https://gist.github.com/dmos62/20981dae799e2fc31b62dd443c44c7ae) for comparison, but it was moot point, because ghubstan's PR was almost done by then. Some of the ideas there were implemented in this PR. It seems to work pretty well right now. Some kinks may (or may not) appear when the number of tests gets high, but we'll cross that bridge when we get there.

Thank you @ghubstan for the work!



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4366#pullrequestreview-453376917
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200722/84afa695/attachment.html>


More information about the bisq-github mailing list