[bisq-network/bisq] PriceNode: Add support for multiple ExchangeRateProviders (#4315)

[wiz]

Thanks for your hard work on this PR. I can't wait to start reviewing it. My first thoughts are:

1) Since we're going to lose hundreds of currencies supported on Bitcoin Average, going down to this new subset of only 12 fiat currencies and 14 crypto currencies, we need to verify this is sufficient for Bisq traders in terms of what is currently actively traded, on a conceptual level.

2) After we verify the new concept makes sense, we need to review the code to make sure the weighted averages work as intended, and test the data works on Bisq nodes without any modifications. Previously some Bisq nodes had issues when JSON elements went missing, so we might need to add dummy empty sets for certain things during the transition period.

3) Once we verify things don't immediately blow up from 1 or 2 above, we can start the actual testing by mixing and matching old BA pricenodes and new non-BA pricenodes with test offers and test trades. The most important thing is that all prices are displayed the same (within tolerances) using a Bisq node only connected to old nodes, and a Bisq node only connected to new nodes.

4) For the actual upgrade later on, in theory if everything works properly, we should even be able to upgrade all the pricenodes separately, but it's probably a good idea to upgrade them all at the same time to avoid minimal fluctuations, so we would have to coordinate a time for all pricenode operators to be online at once.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4315#issuecomment-663165793
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200723/a5385fc7/attachment.html>