[bisq-network/bisq] Warn that seeds are not a data backup (#4379)
Christoph Atteneder
notifications at github.com
Mon Jul 27 08:38:26 UTC 2020
@ripcurlx requested changes on this pull request.
NACK - Just some minor code changes to make the refactoring more verbose. Besides that :+1:
> @@ -163,7 +163,18 @@ public void activate() {
seedWordsTextArea.getStyleClass().remove("validation-error");
restoreDatePicker.getStyleClass().remove("validation-error");
+ new Popup().warning(Res.get("account.seed.backup.warning"))
+ .onAction(() -> {
+ activatePartTwo();
Maybe you could make this more verbose. e.g.
```suggestion
showSeedPhrase();
```
>
+ }
+
+ public void activatePartTwo() {
Maybe you could make this more verbose. e.g.
```suggestion
public void showSeedPhrase() {
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4379#pullrequestreview-455583184
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200727/323cc1a5/attachment.html>
More information about the bisq-github
mailing list