[bisq-network/bisq] Change IP for local node connection to Loopback address (#4373)

QuantumRipple notifications at github.com
Tue Jul 28 10:59:07 UTC 2020


Perhaps I have not been clear about what this PR fixes - my `localhost` _is_ 127.0.0.1. InetAddress.getLocalHost() does _not_ (always) return the address for `localhost`, and is thus not the idiomatic way to get the default loopback address. On my system, for example, it returns the address for my computer's hostname. InetAddress.getLoopbackAddress() returns the IP for localhost.
```
jshell> InetAddress.getLocalHost()
$1 ==> computername/127.0.1.1

jshell> InetAddress.getLoopbackAddress()
$2 ==> localhost/127.0.0.1
```
`0.0.0.0` in the context of the bitcoind configuration file's bind address means listen on all addresses. Other definitions are not applicable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4373#issuecomment-664974028
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200728/6c8ceba7/attachment.html>


More information about the bisq-github mailing list