[bisq-network/bisq] Bisq tries to connect to local (pruned) node even if I specified custom node IP address. (#4303)

[dmos62]

@ripcurlx how we setup our BTC client is complicated. [This](https://github.com/bisq-network/bisq/blob/d9eb1d8435fd58150a7fe60dd906155ad8c81a78/core/src/main/java/bisq/core/btc/nodes/LocalBitcoinNode.java#L53) is a place (not _the_ place, because there's more than one that makes this decision) where we define when to ignore a local BTC node and it doesn't take into account custom BTC nodes being passed.

I worked on cleaning these things up around the time of your leave and made progress, but eventually got bogged down by how difficult it is to describe what the correct behaviour is given all the various parameters, and also because I realised that I'll be more help doing other things at this time, because we're spread thin, so I shelved it (https://github.com/bisq-network/bisq/pull/4292).

Somewhat tangential, but there's also a PR gathering dust that adds detection and handling of misconfigured (e.g. pruning) nodes, including the local node: https://github.com/bisq-network/bisq/pull/4081 in this case it would cause Bisq to not use the pruning local bitcoin node.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4303#issuecomment-665645171
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200729/9c5c99ca/attachment.html>