[bisq-network/bisq] Arbitrator witness signing (#4280)

sqrrm notifications at github.com
Wed Jun 3 14:12:18 UTC 2020

This is a way for legacy arbitrators to repair some of the lost data in the signedwitness store. With ctrl+O from legacy arbitrator support view `SignUnsignedPubKeysWindow` is opened.

There is no change to current behavior of Bisq for a normal user in this PR.

Some more debug log shortcuts have been added as ctrl+shift+key under `PaymentAccountsView`

At the moment `SignSpecificWitnessWindow` is not that interesting, but it might be a good thing to have in the future. It's a way for arbitrators to sign specific `AccountAgeWitnesses`.

Some logging code from `AccountAgeWitnessService` was moved to a separate class.

`cleanSignedWitnesses` in `SignedWitnessService` is not yet in use, but it should probably be used soon. I don't want to enable it in this PR as it would change current behavior, and it also needs persistence to be fixed.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Arbitrator sign single account age witness
  * Test dummy account age witness signing
  * Refactor accountagewitnessservice log helpers
  * Arbitrator signing of AccountAgeWitness with known pubkey
  * Log unique unsigned signer pubkeys
  * Sign unsigned keys

-- File Changes --

    M common/src/main/java/bisq/common/util/Utilities.java (18)
    M core/src/main/java/bisq/core/account/sign/SignedWitness.java (2)
    M core/src/main/java/bisq/core/account/sign/SignedWitnessService.java (95)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (115)
    A core/src/main/java/bisq/core/account/witness/AccountAgeWitnessUtils.java (171)
    M core/src/main/java/bisq/core/trade/protocol/ProcessModel.java (2)
    M core/src/main/resources/i18n/displayStrings.properties (17)
    M core/src/test/java/bisq/core/account/witness/AccountAgeWitnessServiceTest.java (150)
    M desktop/src/main/java/bisq/desktop/main/account/content/PaymentAccountsView.java (22)
    A desktop/src/main/java/bisq/desktop/main/overlays/windows/SignSpecificWitnessWindow.java (208)
    A desktop/src/main/java/bisq/desktop/main/overlays/windows/SignUnsignedPubKeysWindow.java (196)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/agent/arbitration/ArbitratorView.java (14)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200603/8f741a8a/attachment.html>

More information about the bisq-github mailing list