[bisq-network/bisq] Add multiple fee receivers (#4294)

sqrrm notifications at github.com
Thu Jun 11 19:06:54 UTC 2020


This is a rebased version of #4150 with @stejbac's patch applied.

I still worry about the filter distribution but it might be a minor issue compared to adding some kind of cutoff date and extra complexity that way. I have tested this and it seems to work. The only think I can't get to work locally is the propagation of remove filter. It could be an issue of applying recently received filters though, need to look a bit more at it.

@stejbac Do you have any other issues with this PR. Simple is good to adding more stuff indeed less desirable unless we really do need it.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4294

-- Commit Summary --

  * Add list to filter to set btc fee receiver addresses
  * Weighted payout scheme
  * Add ReceiverSelectorTest

-- File Changes --

    M core/src/main/java/bisq/core/filter/Filter.java (20)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (7)
    M core/src/main/java/bisq/core/offer/placeoffer/PlaceOfferModel.java (7)
    M core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java (5)
    M core/src/main/java/bisq/core/trade/protocol/tasks/taker/CreateTakerFeeTx.java (6)
    A core/src/main/java/bisq/core/util/FeeReceiverSelector.java (78)
    M core/src/main/resources/i18n/displayStrings.properties (1)
    M core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java (8)
    M core/src/test/java/bisq/core/user/UserPayloadModelVOTest.java (2)
    A core/src/test/java/bisq/core/util/FeeReceiverSelectorTest.java (107)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java (5)
    M proto/src/main/proto/pb.proto (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4294.patch
https://github.com/bisq-network/bisq/pull/4294.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4294
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200611/963bdbfc/attachment-0001.html>


More information about the bisq-github mailing list