[bisq-network/bisq] Add wallets protection api tests (#4296)

[Stan]

(This PR should be merged after PR [4295](https://github.com/bisq-network/bisq/pull/4295).  Its branch is based on PR 4295's branch.)

This commit includes the following changes:

 * New tests for methods `lockwallet`, `unlockwallet`,
   `removewalletpassword`, and `setwalletpassword`.

 * New `getbalance` method error handing tests to verify
   error message correctness when wallet is locked.

 * Update to `getversion` method test -- now expects `1.3.4`.

 * Check for new `[params]` column header in help text.

This PR replaces [4243](https://github.com/bisq-network/bisq/pull/4243), which had not been kept in sync with commits to tested methods in [4214](https://github.com/bisq-network/bisq/pull/4214).  It also replaces [4268](https://github.com/bisq-network/bisq/pull/4268), which was based on a stale main branch.

Running the test suite will verify all tests pass

(1)  Clone and build branch `wallets-protection-api-tests`

      $ git clone -b wallets-protection-api-tests https://github.com/ghubstan/bisq.git wallets-protection-api-tests

      $ cd wallets-protection-api-tests

      $ ./gradlew clean build -x test

(2)  Run the server on Linux or OSX:  

      $ ./bisq-daemon --apiPassword=xyz --appDataDir=/tmp/newbisqdatadir

(3)  Let the server initialize (sync) for at least 2 minutes.

(4)  Run the bats test suite: 

      $ bats cli/test.sh

All tests should pass.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4296

-- Commit Summary --

  * Rename CoreWalletService -> CoreWalletsService
  * Add rpc wallet(s) protection tests

-- File Changes --

    M cli/test.sh (92)
    R core/src/main/java/bisq/core/grpc/CoreWalletsService.java (4)
    M core/src/main/java/bisq/core/grpc/GrpcWalletService.java (16)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4296.patch
https://github.com/bisq-network/bisq/pull/4296.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4296
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200612/e6227885/attachment.html>