[bisq-network/bisq] Reduce initial request size (#4233)

[Florian Reimair]

@freimair commented on this pull request.



> +            log.error("Could not copy resourceFile {} to {}.\n{}", resourceFileName, destinationFile.getAbsolutePath(), e.getMessage());
+            e.printStackTrace();
+        }
+
+        // split
+        // - get all
+        SplitStore historicalStore = readStore(destinationFile.getName());
+        // - subtract all that is in resource files
+        store.getMap().keySet().removeAll(historicalStore.getMap().keySet());
+
+        // - create new file with leftovers
+        storage.initAndGetPersisted(store, 0);
+        storage.queueUpForSave();
+
+        return historicalStore;
+    }

I see this whole PR a small-as-can-be bugfix for the 3/4 problem. The "followup"-project would be to remove the protobuf-files altogether and make everything work with a proper database (https://github.com/bisq-network/projects/issues/29). When we approach that project, all the file-handling will be removed and cleaned up.

I agree that the implementation is not as clean as could be, but I rather focus my efforts and not do stuff twice.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4233#discussion_r440811638
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200616/51ae56f1/attachment.html>