[bisq-network/bisq] Reduce initial request size (#4233)
notifications at github.com
Tue Jun 16 12:52:21 UTC 2020
@dmos62 thanks for your review. Appreciate it.
First of all, your PR description is correct.
Furthermore, I believe I can address all of your comments in summary:
I see this PR as an as-small-as-possible fix for the 3/4 problem. Yes, files are copied around where they probably do not need to be, APIs could be more readable, return values are ignored or misused, and a lot of other stuff. Thing is, most of the issues you raised have been in the code already and I do not want to touch them. They have proven themselves. Keep the changes small, keep the isolated. Its a minefield.
That being said, https://github.com/bisq-network/projects/issues/29 is in the queue. That project will get rid of the copying files around because there will be no more individual files, the API will need a major overhaul, the filter might get enhanced, the `isSeednode` code will be gone because it prevents our network to fall apart while upgrading from single data stores (now) to multiple (then) -After that is done, it is no longer needed.
Now to your obvious question: why not do it properly? I rather not spend time on reworking the same thing twice :smile: because I am a) a lazy bastard, and b) we need to use the resources we have efficiently. And of course, coding styles and our brains differ, so there is no perfect PR anyways.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github