[bisq-network/bisq] Add rpc method 'getfundingaddresses' (#4299)

Stan notifications at github.com
Tue Jun 16 14:28:16 UTC 2020


@ghubstan commented on this pull request.



> @@ -50,6 +75,68 @@ public long getAvailableBalance() {
         return balance.getValue();
     }
 
+    public long getAddressBalance(String addressString) {
+        Address address = getAddressEntry(addressString).getAddress();
+        return btcWalletService.getBalanceForAddress(address).value;
+    }
+
+    public String getFundingAddresses() {
+        if (!walletsManager.areWalletsAvailable())
+            throw new IllegalStateException("wallet is not yet available");
+
+        if (walletsManager.areWalletsEncrypted() && tempAesKey == null)
+            throw new IllegalStateException("wallet is locked");

How about `isWalletUnlocked()` , returning `true` if the wallet is encrypted, and temporarily unlocked after a call to `unlockWallet(String password, long timeout)` ?

"Available" is taken;  it means the daemon is sufficiently warmed up and the btc & bsq wallets are not `null`. See `walletsManager.areWalletsAvailable()`.

Good call.  I'll create a new PR for this today.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4299#discussion_r440894438
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200616/dd0d2610/attachment-0001.html>


More information about the bisq-github mailing list