[bisq-network/bisq] Factor duplicate unlocked wallet checks into new method (#4312)
Stan
notifications at github.com
Tue Jun 16 15:57:42 UTC 2020
Response to [change request](https://github.com/bisq-network/bisq/pull/4299#discussion_r440769032) in PR [4299](https://github.com/bisq-network/bisq/pull/4299):
This PR should be reviewed/merged after PR [4309](https://github.com/bisq-network/bisq/pull/4309).
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4312
-- Commit Summary --
* Rename CoreWalletService -> CoreWalletsService
* Add rpc wallet(s) protection tests
* Add rpc method 'getfundingaddresses'
* Replace duplicate code in getFundingAddresses
* Add rpc method 'getaddressbalance'
* Add rpc method 'createpaymentacct'
* Call core wallets service methods from CoreApi
* Factor duplicate unlocked wallet checks into new method
-- File Changes --
M cli/src/main/java/bisq/cli/CliMain.java (81)
M cli/test.sh (116)
M core/src/main/java/bisq/core/grpc/CoreApi.java (63)
A core/src/main/java/bisq/core/grpc/CorePaymentAccountsService.java (57)
R core/src/main/java/bisq/core/grpc/CoreWalletsService.java (120)
A core/src/main/java/bisq/core/grpc/GrpcPaymentAccountsService.java (46)
M core/src/main/java/bisq/core/grpc/GrpcServer.java (26)
R core/src/main/java/bisq/core/grpc/GrpcWalletsService.java (54)
M proto/src/main/proto/grpc.proto (38)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4312.patch
https://github.com/bisq-network/bisq/pull/4312.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4312
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200616/8534614e/attachment-0001.html>
More information about the bisq-github
mailing list