[bisq-network/bisq] [WIP] PriceNode: Add support for multiple ExchangeRateProviders (#4315)

Chris Beams notifications at github.com
Wed Jun 17 09:19:58 UTC 2020

There has been some discussion in the project issue (bisq-network/projects#35) about how this change will impact the the way we tolerance differences between prices on the maker and taker side. ("allowance" as @sqrrm called it). Is this something you gave further thought to, @cd2357?

In any case, I wouldn't want to see this change merged and rolled out without a real live testing effort. We really need to try to break this before rolling it out. The changes look reasonable from what little time I've given to reviewing them, but there's no substitute for a real test plan. Could you lay out how you want to do that?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200617/f8c1f4da/attachment.html>

More information about the bisq-github mailing list