[bisq-network/bisq] [WIP] Implement simplest possible trading script (#4257)

Chris Beams notifications at github.com
Thu Jun 18 09:05:59 UTC 2020


I'd recommend holding off on such a change until closer to an initial release, and to think really carefully about it. The reason for mimicking Bitcoin Core is not because all lower case is necessarily best, but because it is perhaps most familiar to people in this space, and more likely to "feel right" to someone working with Bitcoin Core a lot. If we were to follow more general *nix command line utility conventions, I'd recommend kebab case, e.g. the way many unix utilities are named, e.g. `gpg-agent`, `ssh-agent`, `ssh-add` and the way multi-word git subcommands are named, e.g. `git update-index`. This approach gets verbose, though, particularly when we have get/set/remove names like `set-wallet-password`. In any case (pun intended!), I would not recommend using camel case / mixed case / pascal case, because they smell like Java. The CLI should not telegraph the preferences and conventions of the underlying programming language; it should be designed to fit well and feel right in a *nix environment / Bitcoin protocol stack environment. Likewise, if we went with snake case, it would feel perhaps more Python-esque than *nix-native.


Note that it could also be (not now, later) that we choose to go with a more sophisticated approach to the cli involving subcommands, e.g. `bisq-cli order create`, `bisq-cli wallet unlock`, `bisq-cli wallet show`, similar to the way, again, that the Git CLI is designed, (`git remote add <url>`, `git remote show origin`, etc).

So again, my 2 sats are to just hold off for now and let the continuing implementation inform the final design. Make this change once, later, when we're more confident about it, ideally with some real world users having tried things out and given some feedback. HTH.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4257#issuecomment-645886474
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200618/8375a705/attachment.html>


More information about the bisq-github mailing list