[bisq-network/bisq] Refactor getFundingAddresses to use memoization (#4321)

dmos62 notifications at github.com
Thu Jun 18 14:01:52 UTC 2020


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4321

-- Commit Summary --

  * Rename CoreWalletService -> CoreWalletsService
  * Add rpc wallet(s) protection tests
  * Add rpc method 'getfundingaddresses'
  * Replace duplicate code in getFundingAddresses
  * Add rpc method 'getaddressbalance'
  * Add rpc method 'createpaymentacct'
  * Call core wallets service methods from CoreApi
  * Factor duplicate unlocked wallet checks into new method
  * Replace Tuple3 with memoization

-- File Changes --

    M cli/src/main/java/bisq/cli/CliMain.java (81)
    M cli/test.sh (116)
    M core/src/main/java/bisq/core/grpc/CoreApi.java (63)
    A core/src/main/java/bisq/core/grpc/CorePaymentAccountsService.java (57)
    R core/src/main/java/bisq/core/grpc/CoreWalletsService.java (137)
    A core/src/main/java/bisq/core/grpc/GrpcPaymentAccountsService.java (46)
    M core/src/main/java/bisq/core/grpc/GrpcServer.java (26)
    R core/src/main/java/bisq/core/grpc/GrpcWalletsService.java (54)
    M proto/src/main/proto/grpc.proto (38)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4321.patch
https://github.com/bisq-network/bisq/pull/4321.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4321
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200618/0cf23849/attachment-0001.html>


More information about the bisq-github mailing list